Made scripts more readable by moving most logic to functions.

dmenu-configs

@@ -1,9 +1,6 @@
 #!/bin/env bash
 
 # a script to quickly open up one of my many configs
-
-source $HOME/.config/dmenu/config
-
 editor="$TERMINAL -e $EDITOR"
 
 declare -a configs=(
@@ -29,6 +26,13 @@ declare -a configs=(
     "xinitrc - $HOME/.config/X11/xinitrc"
 )
 
+load_config () {
+    source $HOME/.config/dmenu/config
+}
+
+main () {
+    load_config
+
     choice=$(printf '%s\n' "${configs[@]}" | $DMENU -l 10 -p 'Edit config:')
 
     [ -z "$choice" ] && exit
@@ -37,3 +41,6 @@ choice=$(printf '%s\n' "${configs[@]}" | $DMENU -l 10 -p 'Edit config:')
 
     cfg=$(printf '%s\n' "${choice}" | awk '{print $NF}')
     $editor "$cfg"
+}
+
+main $@

dmenu-games

@@ -1,8 +1,9 @@
 #!/bin/sh
 
 # dmenu script to open up my games
-
+load_config () {
     . $HOME/.config/dmenu/config
+}
 
 get_category () {
     category=$( game-run list | $DMENU -p "Choose game category:")
@@ -10,8 +11,7 @@ get_category () {
     [ -z "$category" ] && exit 0
 }
 
-get_category
+menu () {
-
     while [ -z "$game" ]
     do
 
@@ -26,9 +26,24 @@ do
 
         [ -z "$game" ] && get_category
     done
+}
 
+launch_game () {
     if game-run launch "$game"; then
         quick-notify "Game run" "Launching $game"
     else
         quick-notify "Game run" "Failed to launch $game"
     fi
+}
+
+main () {
+    load_config
+
+    get_category
+
+    menu
+
+    launch_game
+}
+
+main $@

dmenu-kill

@@ -2,7 +2,12 @@
 
 # kill those pesky proceses
 
+load_config () {
     . $HOME/.config/dmenu/config
+}
+
+main () {
+    load_config
 
     pid=$(ps -u $USER -o pid,%mem,%cpu,comm,cmd | sort -b -k3 -r | $DMENU -l 15 -i -p "Choose procces to kill: " | awk '{print $1}')
 
@@ -15,3 +20,6 @@ answer=$(printf "yes\\nno" | $DMENU -p "Are you sure?")
     kill -15 $pid 2>/dev/null
 
     quick-notify "Killed Procces" "$pid"
+}
+
+main $@

dmenu-link-handler

@@ -3,8 +3,11 @@
 # Feed this script a link or it will get it from your clipboard and it will give dmenu
 # with some choice of programs to open the link with.
 
+load_config () {
     . $HOME/.config/dmenu/config
+}
 
+menu () {
     case "$(printf "mpv\\nbrowser\\ncopy url [X11]\\ncopy url [Wayland]\\nw3m" | $DMENU -p "Open link with what program?")" in
         mpv) "$VIDEO" "$@" ;;
         browser) "$BROWSER" "$@" > /dev/null;;
@@ -12,3 +15,12 @@ case "$(printf "mpv\\nbrowser\\ncopy url [X11]\\ncopy url [Wayland]\\nw3m" | $DM
         "copy url [Wayland]") echo "$@" | wl-copy -n ;;
         w3m) readable "$@" | w3m -T text/html ;;
     esac
+}
+
+main () {
+    load_config
+
+    menu $@
+}
+
+main $@

dmenu-playerctl

@@ -1,40 +1,28 @@
-#!/bin/bash
+#!/bin/env bash
 
 # script to run a menu prompt when having more than 2 players since
 # playerctl is bad at managing more than one player at the same time
 
+load_config () {
     source $HOME/.config/dmenu/config
+}
+
+main () {
+    load_config
 
     command="$@"
     [ -z "$command" ] && exit
     instances=$(playerctl -l | wc -l)
 
-slock=$(ps -C slock | sed -n '1!p' | awk '{ print $4 }' | sed 's/slock/running/')
-
     if [ "$instances" = "0" ]; then
         exit
     elif [ "$instances" -lt "2" ]; then
         playerctl $command
-elif [ "$slock" = "running" ]; then
-    if [ "$command" = "play-pause" ]; then
-        if playerctl status -a | grep -i "Playing" > /dev/null; then
-            playerctl pause -a
-        else
-            playerctl -p mpd $command
-        fi
-        exit
-    fi
-
-    players=$(paste <(playerctl -l) <(playerctl status -a) | grep -v -i mpd | awk '{print $1}')
-    if [ ! -z "$players" ]; then
-        for player in $players; do
-            playerctl -p $player pause
-        done
-    fi
-
-    playerctl -p mpd $command
     else
         choice=$(playerctl -l | $DMENU -p 'Manage:')
         [ -z "$choice" ] && exit
         playerctl -p $choice $command
     fi
+}
+
+main $@

dmenu-power-menu

@@ -2,9 +2,21 @@
 
 # simple power menu script
 
+load_config () {
     . $HOME/.config/dmenu/config
+}
 
+menu () {
     case "$(printf "shutdown\\nreboot" | $DMENU -p "Choose your poison")" in
         "shutdown") poweroff ;;
         "reboot") reboot ;;
     esac
+}
+
+main () {
+    load_config
+
+    menu
+}
+
+main $@

dmenu-runner

@@ -1,7 +1,15 @@
 #!/bin/sh
 
+load_config () {
     . $HOME/.config/dmenu/config
+}
+
+main () {
+    load_config
 
     choice=$(dmenu_path | grep dmenu- | $DMENU -p "Choose script to run:")
 
     $choice
+}
+
+main $@

dmenu-ryzenadj

@@ -1,8 +1,9 @@
 #!/bin/sh
 
 # dmenu script for quickly setting ryzenadj profiles with my other script easily
-
+load_config () {
     . $HOME/.config/dmenu/config
+}
 
 get_category () {
     category=$( sudo ryzenset list | $DMENU -p "Choose profile category:")
@@ -10,8 +11,7 @@ get_category () {
     [ -z "$category" ] && exit 0
 }
 
-get_category
+get_current_profile () {
-
     current_temp=$(sudo get-tctl-limit)
 
     [ "$current_temp" = "60" ] && current_mode="normal mode"
@@ -19,17 +19,35 @@ current_temp=$(sudo get-tctl-limit)
     [ "$current_temp" = "70" ] && current_mode="heavy gaming"
     [ "$current_temp" = "75" ] && current_mode="heavy programs"
     [ "$current_temp" = "85" ] && current_mode="heavy gaming pro"
+}
 
+menu () {
     while [ -z "$profile" ]
     do
-
         profile=$(sudo ryzenset list $category | $DMENU -p "Current: $current_mode:")
 
         [ -z "$profile" ] && get_category
     done
+}
 
+launch_profile () {
     if sudo ryzenset set "$profile"; then
         quick-notify "Ryzenset" "Setting $profile"
     else
         quick-notify "Ryzenset" "Failed to set $game"
     fi
+}
+
+main () {
+    load_config
+
+    get_category
+
+    get_current_profile
+
+    menu
+
+    launch_profile
+}
+
+main $@

dmenu-screenshot

@@ -2,13 +2,24 @@
 
 # It lets you choose the kind of screenshot to take, including
 # copying the image or even highlighting an area to copy.
-
+load_config () {
     . $HOME/.config/dmenu/config
+}
 
-dir="$HOME/pics/screenshots"
+menu () {
-[ ! -d "$dir" ] && mkdir $dir -p
+    case "$(printf "a selected area\\nfull screen" | $DMENU -l 6 -p "Screenshot which area?")" in
-
-case "$(printf "a selected area\\ncurrent window\\nfull screen\\na selected area (copy)\\ncurrent window (copy)\\nfull screen (copy)" | $DMENU -l 6 -p "Screenshot which area?")" in
         "a selected area") sleep 0.5; shotgun -g $(hacksaw) $dir/pic-selected-"$(date '+%y%m%d-%H%M-%S').png" ;;
         "full screen") sleep 0.5; shotgun $dir/pic-full-"$(date '+%y%m%d-%H%M-%S').png" ;;
     esac
+}
+
+main () {
+    dir="$HOME/pics/screenshots"
+    [ ! -d "$dir" ] && mkdir $dir -p
+
+    load_config
+
+    menu
+}
+
+main $@

dmenu-transmission

@@ -1,10 +1,8 @@
 #!/bin/env bash
 
+load_config () {
     source $HOME/.config/dmenu/config
-
+}
-id=$(transmission-remote -l | $DMENU -l 10 | awk '{print $1}'|  sed 's/*//')
-
-[ -z "$id" ] && exit 0
 
 move () {
     declare -a paths=(
@@ -29,10 +27,9 @@ move () {
     else
         quick-notify "Transmission" "Couldn't move $1 to $choice"
     fi
-
-
 }
 
+menu () {
     case "$(printf "Start\\nStop\\nMove\\nRemove" | $DMENU -p "Torrent Action: ")" in
         Remove) transmission-remote -t $id -rad
             quick-notify "Transmission" "Removed $id"
@@ -48,3 +45,16 @@ case "$(printf "Start\\nStop\\nMove\\nRemove" | $DMENU -p "Torrent Action: ")" i
         *) quick-notify "Transmission" "No action chosen"
             ;;
     esac
+}
+
+main () {
+    load_config
+
+    id=$(transmission-remote -l | $DMENU -l 10 | awk '{print $1}'|  sed 's/*//')
+
+    [ -z "$id" ] && exit 0
+
+    menu
+}
+
+main $@

dmenu-usb-man

@@ -2,7 +2,9 @@
 
 # a simple dmenu usb managment script
 
+load_config () {
     . $HOME/.config/dmenu/config
+}
 
 driveCount(){
     count="$(printf '%s\n' "$1" | wc -l)"
@@ -47,7 +49,17 @@ unmount(){
     fi
 }
 
+menu () {
     case $(printf "mount\\nunmount" | $DMENU -p "Chose your usb action") in
         "mount") mount ;;
         "unmount") unmount ;;
     esac
+}
+
+main () {
+    load_config
+
+    menu
+}
+
+main $@